Skip to content

Deprecate {Locator,Formatter}.set_{{view,data}_interval,bounds}. #13860

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 22, 2021
Merged

Deprecate {Locator,Formatter}.set_{{view,data}_interval,bounds}. #13860

merged 1 commit into from
Apr 22, 2021

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented Apr 3, 2019

Directly manipulating the underlying axis' view and data intervals is
clearer (see e.g. the changes in dates.py which ultimately just deletes
code that sets self.axis's view and data intervals to themselves).

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@anntzer anntzer force-pushed the getviewdataintervals branch 2 times, most recently from a73c905 to 9c7858d Compare April 3, 2019 10:06
@anntzer anntzer force-pushed the getviewdataintervals branch from 9c7858d to 8baad5a Compare June 12, 2019 21:40
@anntzer anntzer force-pushed the getviewdataintervals branch from 8baad5a to 7662fc6 Compare February 12, 2020 10:19
@jklymak jklymak added this to the v3.5.0 milestone Apr 15, 2021
@jklymak
Copy link
Member

jklymak commented Apr 15, 2021

This seems reasonable, but is it necessary? It is difficult for end users to know about methods on properties. i.e. I would need to know the Locator has an axis property, and then I would need to know that the axis object had a set_view_interval on it, and what that does.

@anntzer
Copy link
Contributor Author

anntzer commented Apr 15, 2021

I don't think end users should call these methods at all anyways? In practice these should just be called by internal hooks.

@anntzer anntzer force-pushed the getviewdataintervals branch from 7662fc6 to 9d9bdab Compare April 15, 2021 20:03
@jklymak
Copy link
Member

jklymak commented Apr 15, 2021

ping for review when its passing. Looks good at first glance

@anntzer anntzer force-pushed the getviewdataintervals branch 2 times, most recently from e542bf3 to 053c022 Compare April 16, 2021 08:50
@anntzer
Copy link
Contributor Author

anntzer commented Apr 16, 2021

should be fixed now.

QuLogic
QuLogic reviewed Apr 22, 2021
View reviewed changes
@anntzer
Deprecate {Locator,Formatter}.set_{{view,data}_interval,bounds}.
21e5876 
Directly manipulating the underlying axis' view and data intervals is
clearer (see e.g. the changes in dates.py which ultimately just deletes
code that sets `self.axis`'s view and data intervals to themselves).
@anntzer anntzer force-pushed the getviewdataintervals branch from 053c022 to 21e5876 Compare April 22, 2021 20:38
@QuLogic QuLogic merged commit 2225813 into matplotlib:master Apr 22, 2021
@anntzer anntzer deleted the getviewdataintervals branch April 22, 2021 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@QuLogic QuLogic QuLogic approved these changes

@jklymak jklymak jklymak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v3.5.0
Development

Successfully merging this pull request may close these issues.
3 participants
@anntzer @jklymak @QuLogic