Switch PyArg_ParseTupleAndKeywords from "es" to "s". #13866
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This avoids having to call PyMem_Free ourselves. Note that all call sites either already use utf-8 (which "s" does), or use ascii but then match the string against some ascii-only strings (or glyph names), so the change is fine encoding-wise.
|
The documentation of
How does this match with your statement
|
|
This PR switches from using "es" (which requires manual deallocation) to "s" (which doesn't). |
|
Sorry, I was confused. |
QuLogic
reviewed
Apr 14, 2019
| @@ -1066,15 +1066,10 @@ static PyObject *PyFT2Font_get_name_index(PyFT2Font *self, PyObject *args, PyObj | |||
| { | |||
| char *glyphname; | |||
There was a problem hiding this comment.
FT_Get_Name_Index takes a non-const char* as argument (so we'd need a const_cast... not really worth it IMO? can add it if you prefer), even though it does not actually modify it. See also thread starting at http://lists.nongnu.org/archive/html/freetype/2019-04/msg00004.html.
QuLogic
approved these changes
Apr 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This avoids having to call PyMem_Free ourselves.
Note that all call sites either already use utf-8 (which "s" does), or
use ascii but then match the string against some ascii-only strings (or
glyph names), so the change is fine encoding-wise.
Perhaps this will fix #13865? (which fails with a MemoryError in get_sfnt_table)
edit: well no, this segfaults the doc build.
edit: duh, should be fixed now.
PR Summary
PR Checklist