Skip to content

Correctly handle fallout of defining PY_SSIZE_T_CLEAN on Windows. #13868

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 3, 2019
Merged

Correctly handle fallout of defining PY_SSIZE_T_CLEAN on Windows. #13868

merged 1 commit into from
Apr 3, 2019

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented Apr 3, 2019

PR Summary

Perhaps fixes #13865, given the note at https://docs.python.org/3/c-api/arg.html#strings-and-buffers.

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@dstansby dstansby added this to the v3.1.0 milestone Apr 3, 2019
jklymak
jklymak approved these changes Apr 3, 2019
View reviewed changes
Copy link
Member

@jklymak jklymak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to have made all the tests happy.

@jklymak jklymak requested a review from tacaswell April 3, 2019 17:35
@jklymak
Copy link
Member

jklymak commented Apr 3, 2019

Be good if @tacaswell had a quick look and merged since he made the original change...

@tacaswell tacaswell merged commit acad890 into matplotlib:master Apr 3, 2019
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request Apr 3, 2019
@tacaswell
Backport PR matplotlib#13868: Correctly handle fallout of defining PY…
d074af9 
…_SSIZE_T_CLEAN on Windows.
@meeseeksmachine meeseeksmachine mentioned this pull request Apr 3, 2019
Merged
@tacaswell
Copy link
Member

Thanks for sorting this out @anntzer.

@anntzer anntzer deleted the ssize_t branch April 3, 2019 19:04
dstansby added a commit that referenced this pull request Apr 3, 2019
@dstansby
Merge pull request #13871 from meeseeksmachine/auto-backport-of-pr-13…
6299506 
…868-on-v3.1.x

Backport PR #13868 on branch v3.1.x (Correctly handle fallout of defining PY_SSIZE_T_CLEAN on Windows.)
tacaswell added a commit to tacaswell/matplotlib that referenced this pull request Oct 19, 2019
@tacaswell
Merge pull request matplotlib#13868 from anntzer/ssize_t
99903ba 
FIX: Correctly handle fallout of defining PY_SSIZE_T_CLEAN on Windows.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jklymak jklymak jklymak approved these changes

@dstansby dstansby dstansby approved these changes

@tacaswell tacaswell Awaiting requested review from tacaswell

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v3.1.0
Development

Successfully merging this pull request may close these issues.

Appveyor broken
4 participants
@anntzer @jklymak @tacaswell @dstansby