Skip to content

Clarify handling of "extreme" values in FloatingAxisArtistHelper. #13879

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 2, 2019
Merged

Clarify handling of "extreme" values in FloatingAxisArtistHelper. #13879

merged 1 commit into from
May 2, 2019

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented Apr 4, 2019

  1. Pre-normalize extremes from None to +/- np.inf from the beginning,
    rather than recheck for None every time they are accessed.
  2. Instead of indexing into the 4-element extremes list, just give
    meaningful names to each element.

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@tacaswell tacaswell added this to the v3.2.0 milestone Apr 4, 2019
@anntzer
Clarify handling of "extreme" values in FloatingAxisArtistHelper.
6533873 
1. Pre-normalize extremes from None to +/- np.inf from the beginning,
   rather than recheck for None every time they are accessed.
2. Instead of indexing into the 4-element `extremes` list, just give
   meaningful names to each element.
@dstansby dstansby merged commit aaea1d4 into matplotlib:master May 2, 2019
@anntzer anntzer deleted the extremes branch May 2, 2019 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timhoffm timhoffm timhoffm approved these changes

@dstansby dstansby dstansby approved these changes

Assignees
No one assigned
Labels
topic: mpl_toolkit
Projects
None yet
Milestone
v3.2.0
Development

Successfully merging this pull request may close these issues.
4 participants
@anntzer @timhoffm @dstansby @tacaswell