Skip to content

Add support for metadata= and pil_kwargs= in imsave(). #13902

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 6, 2019
Merged

Add support for metadata= and pil_kwargs= in imsave(). #13902

merged 1 commit into from
May 6, 2019

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented Apr 7, 2019

For consistency with savefig().

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@anntzer
Copy link
Contributor Author

anntzer commented Apr 7, 2019

Not really sure where the test failure comes from, I wonder if it is exposing an issue with multiprocessing...

@tacaswell tacaswell added this to the v3.2.0 milestone Apr 11, 2019
@tacaswell
Copy link
Member

"crashed" sounds like segfault not an exception. Nothing jump out at me either....

@QuLogic
Copy link
Member

QuLogic commented Apr 11, 2019

The problem is that the original path replaces None with an empty dictionary (+ the Software key), but this new one doesn't. The C code doesn't expect or handle None, or even non-dictionary types.

@QuLogic QuLogic mentioned this pull request Apr 11, 2019
Merged
2 tasks
@anntzer anntzer force-pushed the imsavemetadatapilkwargs branch from 943261d to d641704 Compare April 11, 2019 14:05
@anntzer
Copy link
Contributor Author

anntzer commented Apr 11, 2019

@QuLogic thanks, your patch fixed this PR :)

@anntzer anntzer force-pushed the imsavemetadatapilkwargs branch from d641704 to 5e91c5a Compare April 16, 2019 13:08
@dstansby
Copy link
Member

dstansby commented May 6, 2019

Thanks!

@dstansby dstansby merged commit 79c296c into matplotlib:master May 6, 2019
@anntzer anntzer deleted the imsavemetadatapilkwargs branch May 6, 2019 15:58
@anntzer anntzer mentioned this pull request Oct 17, 2019
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timhoffm timhoffm timhoffm approved these changes

@dstansby dstansby dstansby approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v3.2.0
Development

Successfully merging this pull request may close these issues.
5 participants
@anntzer @tacaswell @QuLogic @dstansby @timhoffm