Use PYTHONFAULTHANDLER to switch on the Python fault handler. #13937
Conversation
We don't need custom code in test() or a pytest plugin to do so. (That variable is already set in travis.yml.)
|
What is the harm of turning it on in the test suite? It seems like something we want by default when developres run it on their own machines. |
|
I think that's a bit like asking why Python or pytest don't turn on faulthandler by default. (As mentioned some time ago, I actually set $PYTHONFAULTHANDER=1 in my ~/.profile so it's always on for me, but I assume(?) there are good reasons why this is not a good idea in all cases? Note, also, that setting the environment variable globally works, well, for any project you want to work on instead of having to add faulthandler-setup code to matplotlib, to numpy, to scipy, etc.) Not a huge deal anyways, though we can at least remove pytest-faulthandler from travis_all as that's clearly redundant with the setup code in test() :) |
We don't need custom code in test() or a pytest plugin to do so.
(That variable is already set in travis.yml.)
PR Summary
PR Checklist