Check vmin/vmax are valid when doing inverse in LogNorm #13970
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do we actually need to require that vmin<vmax? It looks like vmin>vmax just results in a "decreasing" log-norm, which isn't really problematic in itself. |
|
I'm not sure, maybe that could be left for another PR/issue though. |
jklymak
approved these changes
Apr 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sort of related to #13967, when calling
inverse()on aLogNormwith invalid limits, there used to be some sort of floating point calculation error, this changes the error to be a bit better and warn the user that the problem is invalidvminorvmaxvalues.