Don't try to use the colorbar formatter to format RGBA data. #14069
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A colorbar doesn't make much sense for RGBA data, but matplotlib does
allow one to be constructed; when formatting the cursor data for a RGBA
image we must be careful to not use the colorbar formatter.
Otherwise, after `plt.imshow(np.random.rand(5, 5, 3)); plt.colorbar()`,
when moving the mouse cursor over the image, we get
```
<elided>
File "/usr/lib/python3.7/site-packages/matplotlib/ticker.py", line 604, in format_data_short
return '%-12g' % value
File "/usr/lib/python3.7/site-packages/numpy/ma/core.py", line 4296, in __float__
raise TypeError("Only length-1 arrays can be converted "
TypeError: Only length-1 arrays can be converted to Python scalars
```
tacaswell
approved these changes
Apr 29, 2019
dstansby
approved these changes
Apr 29, 2019
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Apr 29, 2019
… to format RGBA data.
timhoffm
added a commit
that referenced
this pull request
Apr 29, 2019
…069-on-v3.1.x Backport PR #14069 on branch v3.1.x (Don't try to use the colorbar formatter to format RGBA data.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A colorbar doesn't make much sense for RGBA data, but matplotlib does
allow one to be constructed; when formatting the cursor data for a RGBA
image we must be careful to not use the colorbar formatter.
Otherwise, after
plt.imshow(np.random.rand(5, 5, 3)); plt.colorbar(),when moving the mouse cursor over the image, we get
release critical as a regression from #12459.
PR Summary
PR Checklist