Deprecate FigureCanvasMac.invalidate in favor of draw_idle. #14108
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anntzer
commented
May 1, 2019
| @@ -182,12 +184,7 @@ class _BackendMac(_Backend): | |||
|
|
|||
| @staticmethod | |||
| def trigger_manager_draw(manager): | |||
| # For performance reasons, we don't want to redraw the figure after | |||
There was a problem hiding this comment.
This comment is true, but is not specific to the osx backend -- all interactive backends do the same.
... as that name is standard across most interactive backends (I plan to harmonize the remaining cases -- tk and nbagg -- to use draw_idle as well).
timhoffm
approved these changes
May 1, 2019
dstansby
previously requested changes
May 3, 2019
|
What do you mean? before this PR, draw_idle and invalidate both already exist, with invalidate being implemented in C and draw_idle a trivial wrapper around it. After this PR, it's now draw_idle that's implemented in C and invalidate is a deprecated wrapper around it. |
|
Sorry, I must have missed that bit... |
dstansby
approved these changes
May 3, 2019
|
no worries :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... as that name is standard across most interactive backends (I plan to
harmonize the remaining cases -- tk and nbagg -- to use draw_idle as
well).
PR Summary
PR Checklist