Skip to content

Make test suite fail on warnings. #14131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 6, 2019
Merged

Make test suite fail on warnings. #14131

merged 1 commit into from
May 6, 2019

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented May 4, 2019 •
edited
Loading

PR Summary

There are a few remaining warnings with secondary_axes, which should be handled by #13593 (which, as a side effect, delays applyings margins to the secondary axes until the axes have "valid" limits).

Edits:

  • Looks like test_warn_external_frame_embedded_python had to be slightly adjusted (although it does something nasty by patching sys, so it probably can't really be considered a pytest bug...); done.
  • And some warning with old numpys, also fixed.

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@anntzer anntzer force-pushed the werror branch 2 times, most recently from 0cd9194 to 59a0ce2 Compare May 5, 2019 10:44
@tacaswell tacaswell added this to the v3.2.0 milestone May 6, 2019
@jklymak jklymak merged commit 8b05b35 into matplotlib:master May 6, 2019
@anntzer anntzer deleted the werror branch May 6, 2019 19:31
@anntzer anntzer mentioned this pull request May 6, 2019
Merged
6 tasks
tacaswell added a commit to tacaswell/matplotlib that referenced this pull request Aug 11, 2019
@tacaswell
FIX: un-break nightly wheels on py37
1df96ba 
The issue is that matplotlib#14131
made our test suite fail on any warnings (good!), however we do not
test all versions of numpy and `np.min([np.nan])` seems to warn for
1.14.4 < version < 1.15.0 which is not a range we test on travis.
However, the version of numpy that the wheels pin to for py37 in
1.14.6 which does warn.

This is likely related to numpy/numpy#10370
@tacaswell tacaswell mentioned this pull request Aug 11, 2019
Merged
6 tasks
tacaswell added a commit to tacaswell/matplotlib that referenced this pull request Aug 12, 2019
@tacaswell
FIX: un-break nightly wheels on py37
07533e1 
The issue is that matplotlib#14131
made our test suite fail on any warnings (good!), however we do not
test all versions of numpy and `np.min([np.nan])` seems to warn for
1.14.4 < version < 1.15.0 which is not a range we test on travis.
However, the version of numpy that the wheels pin to for py37 in
1.14.6 which does warn.

This is likely related to numpy/numpy#10370
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tacaswell tacaswell tacaswell approved these changes

@jklymak jklymak jklymak approved these changes

Assignees
No one assigned
Labels
topic: testing
Projects
None yet
Milestone
v3.2.0
Development

Successfully merging this pull request may close these issues.
3 participants
@anntzer @tacaswell @jklymak