Skip to content

Isolate nbagg test from user ipython profile. #14157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 8, 2019

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented May 7, 2019

My ~/.ipython profile causes test_backend_nbagg to fail (but is
otherwise valid for my own use). To fix that, point the ipython
directory to a temporary directory when running that test (per
https://ipython.readthedocs.io/en/stable/config/intro.html#the-ipython-directory).

While we're at it, also create the temporary output file in that
directory -- that's quite likely to be necessary for the test to
actually work on Windows, anyways (due to vagaries with writing from
multiple processes to a NamedTemporaryFile).

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

My ~/.ipython profile causes test_backend_nbagg to fail (but is
otherwise valid for my own use).  To fix that, point the ipython
directory to a temporary directory when running that test (per
https://ipython.readthedocs.io/en/stable/config/intro.html#the-ipython-directory).

While we're at it, also create the temporary output file in that
directory -- that's quite likely to be necessary for the test to
actually work on Windows, anyways (due to vagaries with writing from
multiple processes to a NamedTemporaryFile).
@tacaswell tacaswell merged commit 28e32c6 into matplotlib:master May 8, 2019
@anntzer anntzer deleted the nbaggtest branch May 8, 2019 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants