-
-
Notifications
You must be signed in to change notification settings - Fork 7.9k
Add backend_inline to non_interactive_bk list #14181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add backend_inline to non_interactive_bk list #14181
Conversation
The failure definitely looks real so that will need to be addressed. I do not understand why this change suppresses the warning. The issue seems to be that in I think the correct fix for this is to change what |
All reactions
Sorry, something went wrong.
Also, thank you for your work on this! Sorry my previous comment is mostly negative. |
All reactions
Sorry, something went wrong.
You're right! I got confused by using the At figure.py#L440, it would look like: if manager is not None:
try:
manager.show()
return
except NonGuiException:
pass
if (backends._get_running_interactive_framework() != "headless"
and get_backend() != "module://ipykernel.pylab.backend_inline"
and warn):
cbook._warn_external('Matplotlib is currently using %s, which is '
'a non-GUI backend, so cannot show the '
'figure.' % get_backend()) |
All reactions
Sorry, something went wrong.
As suggested by @tacaswell above, I think the correct fix lives on ipykernel's side, as matplotlib can't possibly keep track of each and every backend that exists out there. |
All reactions
Sorry, something went wrong.
Yes, makes sense! |
All reactions
Sorry, something went wrong.
I'm going to close this @nitrofortin please let us know if you need any help over on the iptyhon/jupyter side! Hope we hear from you again. |
All reactions
Sorry, something went wrong.
Thank you, I will investigate on the ipython side how this could be fixed :) |
All reactions
Sorry, something went wrong.
Was an issue / PR ever opened on the jupyter side? |
All reactions
Sorry, something went wrong.
No! |
All reactions
Sorry, something went wrong.
Successfully merging this pull request may close these issues.
None yet
It tackles #14171. By adding module://ipykernel.pylab.backend_inline to the list of non interactive backends, the Jupyter notebook warning don't show up anymore. Let me know what you think!
PR Summary
PR Checklist