Skip to content

Avoid a buffer copy in PillowWriter. #14242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 18, 2019
Merged

Avoid a buffer copy in PillowWriter. #14242

merged 1 commit into from
May 18, 2019

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented May 18, 2019

PR Summary

frombuffer was added in Pillow 1.1.4 https://pillow.readthedocs.io/en/stable/reference/Image.html#PIL.Image.frombuffer and we document only supporting Pillow>=3.4 (https://matplotlib.org/users/prev_whats_new/whats_new_2.2.html#writing-animations-with-pillow).

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@tacaswell tacaswell added this to the v3.2.0 milestone May 18, 2019
@tacaswell tacaswell merged commit 4a9b1c1 into matplotlib:master May 18, 2019
@anntzer anntzer deleted the animatecopy branch May 18, 2019 16:15
@anntzer anntzer mentioned this pull request Nov 12, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timhoffm timhoffm timhoffm approved these changes

Assignees
No one assigned
Labels
topic: animation
Projects
None yet
Milestone
v3.2.0
Development

Successfully merging this pull request may close these issues.
3 participants
@anntzer @timhoffm @tacaswell