Skip to content

Use png files for all icon files in backend_qt4.py instead of svg #143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

ruidc
Copy link

@ruidc ruidc commented Jun 14, 2011

Use png files for all icon files in backend_qt4.py instead of svg to circumvent dependency in Qt:
http://sourceforge.net/mailarchive/forum.php?thread_name=4D4EA423.5090802%40vanderHoeven.biz&forum_name=matplotlib-users

@gstorer
Copy link
Contributor

gstorer commented Jun 15, 2011

The problem described in that thread is by and large just a problem with py2exe not knowing what to do with the Qt imageformat plugin DLLs. See this for a more detail explanation: http://stackoverflow.com/questions/4573995/pyqt-pyside-icon-display-problem/5643540#5643540

I'm not quite sure the reasoning behind using SVG, if there isn't a good reason then Qt backend should use the .png images as Qt natively supports PNG. If there's a reason for SVG then the problem described is just a quirk of the py2exe and Qt combination that is easy enough to work around when you know what's causing it.

@ruidc
Copy link
Author

ruidc commented Jun 15, 2011

"I'm not quite sure the reasoning behind using SVG, if there isn't a good reason then Qt backend should use the .png images as Qt natively supports PNG." - This is my point, as one of the icons was already using PNG, and this way, if there's no good reason for using SVG, we avoid an extra (non-obvious) dependency.

@ddale ddale closed this in c61df40 Jun 15, 2011
@ddale
Copy link
Contributor

ddale commented Jun 15, 2011

I applied the changes to the v1.0.x-maint branch, and merged that into master. I suggest you not file pull requests from your master branch, as it has now diverged from upstream/master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants