Skip to content

Use cbook._check_in_list more often. #14350

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 28, 2019
Merged

Use cbook._check_in_list more often. #14350

merged 1 commit into from
May 28, 2019

Conversation

QuLogic
Copy link
Member

@QuLogic QuLogic commented May 28, 2019

PR Summary

Pretty much what it says in the title. Should get more consistency in error messages, too.

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • [N/A] New features are documented, with examples if plot related
  • [N/A] Documentation is sphinx and numpydoc compliant
  • [N/A] Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • [N/A] Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@tacaswell tacaswell added this to the v3.2.0 milestone May 28, 2019
@tacaswell tacaswell merged commit 2c22cc6 into matplotlib:master May 28, 2019
@QuLogic QuLogic deleted the check-in-list branch May 28, 2019 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anntzer anntzer anntzer approved these changes

Assignees
No one assigned
Labels
API: argument checking
Projects
None yet
Milestone
v3.2.0
Development

Successfully merging this pull request may close these issues.
3 participants
@QuLogic @anntzer @tacaswell