Check that the figure patch is in bbox_artists before trying to remove. #14374
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timhoffm
approved these changes
May 30, 2019
anntzer
approved these changes
May 30, 2019
|
thanks, hoping to see you around again :) |
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
May 30, 2019
…artists before trying to remove.
6 tasks
timhoffm
added a commit
that referenced
this pull request
May 30, 2019
…374-on-v3.1.x Backport PR #14374 on branch v3.1.x (Check that the figure patch is in bbox_artists before trying to remove.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
When frameon=False is used the figure patch is not visible, it therefore is not added to bbox_artists in get_default_bbox_extra_artists and an exception is raised once bbox_artist.remove is called.
This simply adds a check to determine if the figure patch is present in bbox_artists.
PR Checklist