Skip to content

Remove setup_method #14378

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 30, 2019
Merged

Remove setup_method #14378

merged 1 commit into from
May 30, 2019

Conversation

timhoffm
Copy link
Member

@timhoffm timhoffm commented May 30, 2019 •
edited
Loading

PR Summary

Sort of adresses #6731

Replace setup_method and etc methods with fixtures

The setup_method does only produce test data. But essentially every method within the test case uses different data. So it's simpler to create that data locally just within the test.

@timhoffm timhoffm added this to the v3.2.0 milestone May 30, 2019
anntzer
anntzer approved these changes May 30, 2019
View reviewed changes
Copy link
Contributor

@anntzer anntzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

modulo CI

@dstansby dstansby merged commit 771bb19 into matplotlib:master May 30, 2019
@timhoffm timhoffm deleted the remove-setup_method branch May 30, 2019 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anntzer anntzer anntzer approved these changes

Assignees
No one assigned
Labels
topic: testing
Projects
None yet
Milestone
v3.2.0
Development

Successfully merging this pull request may close these issues.
3 participants
@timhoffm @anntzer @dstansby