Fix incorrect conversion in PEP8 fixes. #1440
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This code wasn't quite correctly translated when making PEP8 fixes.
|
I've marked this 1.2.x, but I'm not sure yet if this is part of the PEP8 fixes that made it in. Just want to make really sure we don't accidentally release with this. |
|
And to answer my own question: it doesn't look like 1.2.x has the problem. |
|
I already fixed this in #1420 a long time ago this also includes a test. Can you please see if anything else is needed |
|
Closing as duplicate of #1420. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This code wasn't quite correctly translated when making PEP8 fixes, commit 2f11dee.
This breaks inline graphics in the ipython notebook.