Assume that mpl-data is in its standard location. #14401
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous candidates tested in get_candidate_paths were for 1) when matplotlib itself was a namespace package (a long time ago, before mpl_toolkits were move out of matplotlib proper), and 2) py2exe support, which is deprecated (see deprecation of get_py2exe_datafiles). Just to be sure in case someone else is relying on the paths in get_candidate_paths, emit a deprecation warning in case they are needed, but let's not bother with an API changes note (it's not even clear how to word that). Note that redistributors (e.g. linux distro packagers) who may want to move mpl-data out can still do so by patching out the entire `_get_data_path` function.
timhoffm
approved these changes
Jun 3, 2019
|
attn @sandrotosi @QuLogic |
This was referenced Mar 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous candidates tested in get_candidate_paths were for
before mpl_toolkits were move out of matplotlib proper), and
get_py2exe_datafiles).
Just to be sure in case someone else is relying on the paths in
get_candidate_paths, emit a deprecation warning in case they are needed,
but let's not bother with an API changes note (it's not even clear how
to word that).
Note that redistributors (e.g. linux distro packagers) who may want to
move mpl-data out can still do so by patching out the entire
_get_data_pathfunction.PR Summary
PR Checklist