Skip to content

Issue #14372 - Add degrees to documentation #14438

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 4, 2019

Conversation

RoryIAngus
Copy link
Contributor

This is in response to the issue #14372 which wanted the doco updated to reflect that it is in degrees, not radians.

#14372

PR Summary

Update to documentation as per the issue. I have made it very clear that it is degrees that are required. Possibly a bit too much, but I know how easy it is to not see something when you are rushing.

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

This is in response to the issue matplotlib#14372 which wanted the doco updated to reflect that it is in degrees not radians.

matplotlib#14372
@tacaswell tacaswell added this to the v3.1.1 milestone Jun 4, 2019
@tacaswell tacaswell requested a review from WeatherGod June 4, 2019 14:16
Copy link
Member

@tacaswell tacaswell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@timhoffm timhoffm merged commit 32c7f42 into matplotlib:master Jun 4, 2019
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request Jun 4, 2019
@timhoffm
Copy link
Member

timhoffm commented Jun 4, 2019

Thanks, and congratulations to your first commit to matplotlib! Maybe see you back some time.

@timhoffm
Copy link
Member

timhoffm commented Jun 4, 2019

Closes #14372.

timhoffm added a commit that referenced this pull request Jun 4, 2019
…438-on-v3.1.x

Backport PR #14438 on branch v3.1.x (Issue #14372 - Add degrees to documentation)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants