canvas.blit() already defaults to blitting the full figure canvas. #14460
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... so
canvas.blit(figure.bbox)
can be replaced bycanvas.blit()
.The argumentless form is actually more accurate because the computation
of
figure.bbox
can suffer from floating point inaccuracies, which,even if correctly taken into account, could lead to blitting one
row/column too few or too many, whereas
canvas.blit()
with noarguments will, well, always blit the full canvas.
Noted in #14225 (which this fixes, even though a separate fix to bettertake into account the floating point inaccuracies is also coming).
PR Summary
PR Checklist