Skip to content

canvas.blit() already defaults to blitting the full figure canvas. #14460

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 7, 2019

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented Jun 6, 2019

... so canvas.blit(figure.bbox) can be replaced by canvas.blit().

The argumentless form is actually more accurate because the computation
of figure.bbox can suffer from floating point inaccuracies, which,
even if correctly taken into account, could lead to blitting one
row/column too few or too many, whereas canvas.blit() with no
arguments will, well, always blit the full canvas.

Noted in #14225 (which this fixes, even though a separate fix to bettertake into account the floating point inaccuracies is also coming).

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

... so `canvas.blit(figure.bbox)` can be replaced by `canvas.blit()`.

The argumentless form is actually more accurate because the computation
of `figure.bbox` can suffer from floating point inaccuracies, which,
even if correctly taken into account, could lead to blitting one
row/column too few or too many, whereas `canvas.blit()` with no
arguments will, well, always blit the full canvas.
Copy link
Member

@WeatherGod WeatherGod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense

@tacaswell tacaswell added this to the v3.2.0 milestone Jun 7, 2019
@tacaswell tacaswell merged commit 07c716f into matplotlib:master Jun 7, 2019
@anntzer anntzer deleted the blitfull branch June 7, 2019 06:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants