FIX: don't close figures if switch_backend is a no-op #14471
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anntzer
reviewed
Jun 6, 2019
anntzer
previously approved these changes
Jun 6, 2019
9bb75fe to
02d3c1b
Compare
b4f9ebb to
3eeb476
Compare
dopplershift
previously approved these changes
Aug 19, 2019
30ebdf9 to
78ca4cb
Compare
|
rebased, but there is something funny going on here, pushed to 3.3. |
This was referenced Dec 12, 2019
78ca4cb to
5ee99ae
Compare
5ee99ae to
a7e7cf1
Compare
a7e7cf1 to
5ebb5f9
Compare
|
Can we have some documentation on the behavior; maybe in the |
timhoffm
approved these changes
Sep 7, 2022
|
This took us just 6 releases. 😮 |
|
@anntzer can you weigh in on this again so Tom doesn't have to rebase any more? |
anntzer
approved these changes
Oct 23, 2022
|
I'm still not really convinced it's the right approach (per my comment above), also I'd say that if we really want to go that route we should skip closing whenever the event loops are compatible (e.g. going from qtagg to qtcairo), not just when the backends are exactly equal. OTOH we can always decide on that later and I don't feel overly strongly about this. |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this should go in for 3.1.1 as it helps to reduce the
action-at-a-distance issues around the auto-backend / IPython
configuration.