Skip to content

Conversation

timhoffm
Copy link
Member

@timhoffm timhoffm commented Jun 8, 2019

PR Summary

The parameter was fig was deprecated in favor of figure in f8dfea7. While it has already been removed in the derived classes, is is still present in the base class (probably because there was no explicit deprecation there).

Removing without further deprecation because

  1. The deprecation has been announced in the change note in f8dfea7.
  2. Likely nobody will ever call GridSpecBase.get_subplot_params() as it does not have any effect.
  3. If somebody still calls it, that's probably an undetected error.

@tacaswell
Copy link
Member

Removed from the subsclasses in 04aea74 for 3.1.

@tacaswell tacaswell merged commit d197f42 into matplotlib:master Aug 7, 2019
@timhoffm timhoffm deleted the deprecate-get_subplot_params-fig branch August 8, 2019 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants