Skip to content

Fix axis inversion with loglocator and logitlocator. #14623

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 27, 2019
Merged

Fix axis inversion with loglocator and logitlocator. #14623

merged 1 commit into from
Jun 27, 2019

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented Jun 25, 2019 •
edited
Loading

PR Summary

Closes #14615 and #14620. Note that this is only for 3.1.x, a separate PR (#14624) is for master.

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@anntzer anntzer added the Release critical For bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions. label Jun 25, 2019
@anntzer anntzer added this to the v3.1.1 milestone Jun 25, 2019
@anntzer anntzer mentioned this pull request Jun 25, 2019
Merged
6 tasks
@anntzer anntzer force-pushed the loglocatororder31 branch from 06a13b2 to af1ab00 Compare June 25, 2019 16:58
@ivanov ivanov mentioned this pull request Jun 27, 2019
Merged
@ivanov
Copy link
Member

ivanov commented Jun 27, 2019

Thanks @anntzer and @timhoffm

@ivanov ivanov merged commit 5544485 into matplotlib:v3.1.x Jun 27, 2019
@anntzer anntzer deleted the loglocatororder31 branch June 27, 2019 19:50
@ivanov
Copy link
Member

ivanov commented Jun 28, 2019

hmmm... not sure how these tests passed, but locally for me this change breaks pytest lib/matplotlib/tests/test_dates.py::test_date_inverted_limit (where the vertical date axis is no longer inverted)

@anntzer anntzer mentioned this pull request Jun 28, 2019
Merged
6 tasks
@anntzer
Copy link
Contributor Author

anntzer commented Jun 28, 2019

Sorry, not sure what happened. See #14643 for a second fix.
PS: please do explicitly ping me in such cases; I tend to mute out closed PRs and issues to keep things manageable...

@ivanov
Copy link
Member

ivanov commented Jun 28, 2019

thanks, @anntzer, will do in the future.

@ivanov ivanov mentioned this pull request Jun 30, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timhoffm timhoffm timhoffm approved these changes

Assignees
No one assigned
Labels
Release critical For bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions.
Projects
None yet
Milestone
v3.1.1
Development

Successfully merging this pull request may close these issues.
3 participants
@anntzer @ivanov @timhoffm