Skip to content

Second attempt at fixing axis inversion (for mpl3.1). #14643

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 28, 2019
Merged

Second attempt at fixing axis inversion (for mpl3.1). #14643

merged 1 commit into from
Jun 28, 2019

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented Jun 28, 2019

Turns out that the behavior of nonsingular() and limit_range_for_scale()
w.r.t. respecting argument order is all over the place, so just re-sort
the axis limits after-the-fact.

Closes #14623 (comment).

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@anntzer
Second attempt at fixing axis inversion (for mpl3.1).
7f7b048 
Turns out that the behavior of nonsingular() and limit_range_for_scale()
w.r.t. respecting argument order is all over the place, so just re-sort
the axis limits after-the-fact.
@anntzer anntzer added the Release critical For bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions. label Jun 28, 2019
@anntzer anntzer added this to the v3.1.1 milestone Jun 28, 2019
This was referenced Jun 28, 2019
Merged
Merged
@ivanov ivanov merged commit 5b1074d into matplotlib:v3.1.x Jun 28, 2019
@anntzer anntzer deleted the moreaxisinversion branch June 29, 2019 09:29
@ivanov ivanov mentioned this pull request Jun 30, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ivanov ivanov ivanov approved these changes

Assignees
No one assigned
Labels
Release critical For bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions.
Projects
None yet
Milestone
v3.1.1
Development

Successfully merging this pull request may close these issues.
2 participants
@anntzer @ivanov