Skip to content

More shortening of setup.py prints. #14673

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 3, 2019
Merged

More shortening of setup.py prints. #14673

merged 1 commit into from
Jul 3, 2019

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented Jul 2, 2019

We don't really need to support "sections" in the packages list.
This PR makes the output go from

BUILDING MATPLOTLIB
  matplotlib: yes [3.1.0+1287.g04d9d28b8]
      python: yes [3.7.3 (default, Jun 24 2019, 04:54:02)  [GCC 9.1.0]]
    platform: yes [linux]

OPTIONAL SUBPACKAGES
 sample_data: yes [installing]
       tests: no  [skipping due to configuration]

OPTIONAL BACKEND EXTENSIONS
         agg: yes [installing]
       tkagg: yes [installing; run-time loading from Python Tcl/Tk]
      macosx: no  [Mac OS-X only]

to

BUILDING MATPLOTLIB
  matplotlib: yes [3.1.0+1287.g04d9d28b8.dirty]
      python: yes [3.7.3 (default, Jun 24 2019, 04:54:02)  [GCC 9.1.0]]
    platform: yes [linux]
 sample_data: yes [installing]
       tests: no  [skipping due to configuration]
         agg: yes [installing]
       tkagg: yes [installing; run-time loading from Python Tcl/Tk]
      macosx: no  [Mac OS-X only]

(and note that the "agg" and "tkagg" entries are being removed by a
separate PR (#13075), as they're not configurable anyways...)

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@anntzer
More shortening of setup.py prints.
5a775a8 
We don't really need to support "sections" in the packages list.
This PR makes the output go from
```
BUILDING MATPLOTLIB
  matplotlib: yes [3.1.0+1287.g04d9d28b8]
      python: yes [3.7.3 (default, Jun 24 2019, 04:54:02)  [GCC 9.1.0]]
    platform: yes [linux]

OPTIONAL SUBPACKAGES
 sample_data: yes [installing]
       tests: no  [skipping due to configuration]

OPTIONAL BACKEND EXTENSIONS
         agg: yes [installing]
       tkagg: yes [installing; run-time loading from Python Tcl/Tk]
      macosx: no  [Mac OS-X only]
```
to
```
BUILDING MATPLOTLIB
  matplotlib: yes [3.1.0+1287.g04d9d28b8.dirty]
      python: yes [3.7.3 (default, Jun 24 2019, 04:54:02)  [GCC 9.1.0]]
    platform: yes [linux]
 sample_data: yes [installing]
       tests: no  [skipping due to configuration]
         agg: yes [installing]
       tkagg: yes [installing; run-time loading from Python Tcl/Tk]
      macosx: no  [Mac OS-X only]
```
(and note that the "agg" and "tkagg" entries are being removed by a
separate PR, as they're not configurable anyways...)
@anntzer anntzer added the Build label Jul 2, 2019
@tacaswell tacaswell added this to the v3.2.0 milestone Jul 3, 2019
@tacaswell tacaswell merged commit 66628cc into matplotlib:master Jul 3, 2019
@anntzer anntzer deleted the setupprint branch July 3, 2019 06:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timhoffm timhoffm timhoffm approved these changes

Assignees
No one assigned
Labels
Build
Projects
None yet
Milestone
v3.2.0
Development

Successfully merging this pull request may close these issues.
3 participants
@anntzer @timhoffm @tacaswell