-
-
Notifications
You must be signed in to change notification settings - Fork 7.9k
Pin pydocstyle<4.0 #14710
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pin pydocstyle<4.0 #14710
Conversation
I am slowly coming around to using one of the auto-dependency version bots for non-user-facing dev tools (pytest, pycodestlyle, and friends). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's get this in to unbreak the build.
Owee, I'm MrMeeseeks, Look at me. There seem to be a conflict, please backport manually. Here are approximate instructions:
And apply the correct labels and milestones. Congratulation you did some good work ! Hopefully your backport PR will be tested by the continuous integration and merged soon! If these instruction are inaccurate, feel free to suggest an improvement. |
Owee, I'm MrMeeseeks, Look at me. There seem to be a conflict, please backport manually. Here are approximate instructions:
And apply the correct labels and milestones. Congratulation you did some good work ! Hopefully your backport PR will be tested by the continuous integration and merged soon! If these instruction are inaccurate, feel free to suggest an improvement. |
Does not need backporting because the usage of pydocstyle itself was not backported #14063. I don't think that it's necessary in the other branches because virtually all doc-string related changes will go into master and only then backported. So they are already checked with the master. |
FTR pydocstyle finally merged my (old) PR which should fix (at least some of) the issues here (PyCQA/pydocstyle#472) so it may be worth looking at whether pydocstyle master works or whether more fixes are needed. |
PR Summary
pydocstyle 4.0.0 was released yesterday and removed a function that is used in flake8-docstrings.
See https://gitlab.com/pycqa/flake8-docstrings/issues/36
This breaks our flake8 tests. Until the above issue is resolved, we should not use pydocstyle 4.0.