Skip to content

Conversation

timhoffm
Copy link
Member

@timhoffm timhoffm commented Jul 7, 2019

PR Summary

This unites the examples

Both illustrate the plotting behavior for non-defined values. But descriptions were very short and the chosen plots are not quite illustrative. Therefore, I rewrote a combined example which is hopefully more instructive.

@timhoffm timhoffm force-pushed the example-masked-nan branch from 7bbae8f to 8cb5b36 Compare July 8, 2019 19:15
Copy link
Member

@jklymak jklymak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made a slight change, but hopefully small enough that no one minds merging

@timhoffm timhoffm force-pushed the example-masked-nan branch from de7f799 to 629a65c Compare July 17, 2019 18:44
Copy link
Member

@QuLogic QuLogic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small typo. Merge when fixed.

Co-Authored-By: Elliott Sales de Andrade <quantum.analyst@gmail.com>
@timhoffm
Copy link
Member Author

May be squash-and-merged via the button.

@QuLogic QuLogic merged commit f4ecebc into matplotlib:master Jul 18, 2019
@QuLogic QuLogic added this to the v3.2.0 milestone Jul 18, 2019
@timhoffm timhoffm deleted the example-masked-nan branch July 18, 2019 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants