Deduplicate wx configure_subplots tool. #14732
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
... by using the old toolbar implementation instead.
anntzer
commented
Jul 9, 2019
| @@ -1406,13 +1406,13 @@ def pan(self, *args): | |||
| self.ToggleTool(self.wx_ids['Zoom'], False) | |||
| NavigationToolbar2.pan(self, *args) | |||
|
|
|||
| def configure_subplots(self, evt): | |||
There was a problem hiding this comment.
very technically this is also a backwards incompatible change because one cannot pass evt as kwarg anymore, but I'm not going to lose sleep over that (the signature is now consistent with pan and zoom).
timhoffm
approved these changes
Jul 10, 2019
QuLogic
approved these changes
Jul 17, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... by using the old toolbar implementation instead.
Basically the same as #14569, but for wx.
PR Summary
PR Checklist