Clearer calls to ConnectionPatch. #14809
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
... by moving the transform next to the xy values, and by using transforms rather than splitting the transform in two separate keyword arguments (axesA and coordsA).
QuLogic
approved these changes
Jul 18, 2019
timhoffm
approved these changes
Jul 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... by moving the transform next to the xy values, and by using
transforms rather than splitting the transform in two separate keyword
arguments (axesA and coordsA).
I know a similar suggestion for Annotation was rejected in #13515, but for the case of ConnectorPatch I think the split of the transform in two argument hampers readibility even more...
PR Summary
PR Checklist