FIX: restore special casing of shift-enter in notebook #14830
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rather than triggering select-next, which may be an arbitrarily other cell
|
@SylvainCorlay not sure if this is going to affect ipympl. |
timhoffm
approved these changes
Jul 17, 2019
dstansby
approved these changes
Jul 21, 2019
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Jul 21, 2019
…ter in notebook
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Jul 21, 2019
…ter in notebook
dstansby
added a commit
that referenced
this pull request
Jul 21, 2019
…830-on-v3.1.x Backport PR #14830 on branch v3.1.x (FIX: restore special casing of shift-enter in notebook)
tacaswell
added a commit
that referenced
this pull request
Oct 15, 2019
…830-on-v2.2.x Backport PR #14830 on branch v2.2.x (FIX: restore special casing of shift-enter in notebook)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR re-applies the fix from @minrk from last time
previous reports:
jupyter/notebook#1124
jupyter/notebook#949
current report:
closes jupyter/notebook#4636
fix:
#6752
accidental revert:
#9027