Fix animation blitting for plots with shared axes #14880
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ImportanceOfBeingErnest
approved these changes
Jul 24, 2019
timhoffm
approved these changes
Jul 24, 2019
|
Thanks, and congratulations on your first contribution to Matplotlib! Maybe see you back some time. |
|
@timhoffm Thank you too. This bug annoyed me for a month until I decided to examine the code =) Well, it appeared to be not that hard after all. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there!
Let me introduce a small but very useful fix for animation blitting for plots which share axes.
Currently, we enumerate artists to both cache background and draw artists in a single pass. But imagine we've got twin plot that share the same axis. As the first sibling draws foreground before the second managed to cache the background we've got incorrect background for the second sibling!
Fortunately, it's easy to fix if we cache background and draw foreground with two distinct passes. Please apply this change because it's very annoying to not have animated twin plots.