Skip to content

Replace some polar baseline images by check_figures_equal. #14888

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 3, 2019
Merged

Replace some polar baseline images by check_figures_equal. #14888

merged 1 commit into from
Sep 3, 2019

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented Jul 25, 2019

PR Summary

Preliminary to #14852, which will regen all polar baseline images.

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@anntzer anntzer mentioned this pull request Jul 25, 2019
Merged
6 tasks
@anntzer anntzer force-pushed the fewer-polar-baseline-images branch from 6db449e to f9cccde Compare July 28, 2019 21:45
@tacaswell tacaswell added this to the v3.3.0 milestone Aug 12, 2019
@anntzer anntzer force-pushed the fewer-polar-baseline-images branch from f9cccde to 8a7f71a Compare August 12, 2019 20:49
@NelleV
Copy link
Member

NelleV commented Sep 3, 2019

Do you know why the circle-ci builds are failing?

@anntzer anntzer force-pushed the fewer-polar-baseline-images branch from 8a7f71a to 1096596 Compare September 3, 2019 09:30
@anntzer
Copy link
Contributor Author

anntzer commented Sep 3, 2019

looks like the usual missing references problem, rebased.

@NelleV NelleV merged commit 46bf4d4 into matplotlib:master Sep 3, 2019
@NelleV
Copy link
Member

NelleV commented Sep 3, 2019

Thanks!

@anntzer anntzer deleted the fewer-polar-baseline-images branch September 3, 2019 09:58
@tacaswell tacaswell modified the milestones: v3.3.0, v3.2.0 Sep 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timhoffm timhoffm timhoffm approved these changes

Assignees
No one assigned
Labels
topic: polar topic: testing
Projects
None yet
Milestone
v3.2.0
Development

Successfully merging this pull request may close these issues.
4 participants
@anntzer @NelleV @timhoffm @tacaswell