Deprecate some FT2Image methods. #14906
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
QuLogic
approved these changes
Aug 2, 2019
timhoffm
reviewed
Aug 10, 2019
lib/matplotlib/contour.py
Outdated
| @@ -249,7 +249,7 @@ def get_label_width(self, lev, fmt, fsize): | |||
| self._mathtext_parser = mathtext.MathTextParser('bitmap') | |||
| img, _ = self._mathtext_parser.parse(lev, dpi=72, | |||
| prop=self.labelFontProps) | |||
| lw = img.get_width() # at dpi=72, the units are PostScript points | |||
| lw, _ = np.shape(img) # at dpi=72, the units are PostScript points | |||
There was a problem hiding this comment.
Couldn't really follow the image definition, but are you sure the width is the number of rows (not columns)?
FT2Image is a class in ft2font that's basically a numpy array (... but predates Matplotlib's use of numpy...). We can't completely remove it yet because that requires adapating some methods implemented in C to take a numpy array (technically, a Python buffer) rather than an FT2Image, but we can start by deprecating some methods which should not be specific to FT2Image, but just be normal operators working on ndarrays.
timhoffm
approved these changes
Aug 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FT2Image is a class in ft2font that's basically a numpy array (... but
predates Matplotlib's use of numpy...). We can't completely remove it
yet because that requires adapating some methods implemented in C to
take a numpy array (technically, a Python buffer) rather than an
FT2Image, but we can start by deprecating some methods which should not
be specific to FT2Image, but just be normal operators working on
ndarrays.
PR Summary
PR Checklist