More Axis3D cleanup. #14963
Merged
More Axis3D cleanup. #14963
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
QuLogic
reviewed
Aug 2, 2019
| Deprecations | ||
| ```````````` | ||
|
|
||
| ``axis3d.get_flip_min_max`` is deprecated. |
There was a problem hiding this comment.
Doesn't this reference need an initial dot?
There was a problem hiding this comment.
Oh wait, that's just code style; why not the full path then?
There was a problem hiding this comment.
Added mplot3d in front; as a rule I tend to not put the leading "matplotlib" or "mpl_toolkits" (it's a bit repetitive otherwise).
It's code style because the link is about to be broken.
lib/mpl_toolkits/mplot3d/axis3d.py
Outdated
| *centers* by *deltas*. | ||
| """ | ||
| coord = np.asarray(coord) | ||
| return coord + axmask * np.sign(coord - centers) * deltas |
There was a problem hiding this comment.
This is not exactly the same, but I'm not sure if it's important, as if coord == centers, then np.sign will return 0 and no movement will be made at all.
There was a problem hiding this comment.
fair point, fortunately I can use copysign() to fix that.
- Use ndarray.copy instead of copy.copy. - "Inline" get_flip_min_max. - Vectorize move_from_center. - Pass 3-tuples as `*xyz` instead of `xyz[0], xyz[1], xyz[2]` to maintain them as "single" objects. - Convert `pep` to an array immediately. - Use more explicit way to count nonzero elements.
timhoffm
approved these changes
Aug 10, 2019
WeatherGod
approved these changes
Aug 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
*xyzinstead ofxyz[0], xyz[1], xyz[2]tomaintain them as "single" objects.
pepto an array immediately.PR Summary
PR Checklist