Skip to content

Use warnings.warn, not logging.warning, in microseconds locator warning. #15000

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 7, 2019
Merged

Use warnings.warn, not logging.warning, in microseconds locator warning. #15000

merged 1 commit into from
Aug 7, 2019

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented Aug 7, 2019

Otherwise something like

from pylab import *
from matplotlib import dates; from datetime import *
plt.plot([datetime(1990, 1, 1), datetime(1990, 1, 1) + timedelta(microseconds=1500)], [0, 0])
plt.show()

results in the same warning being emitted multiple times for every
draw (e.g. when zooming/panning), which is pretty needless spam.

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@timhoffm timhoffm added this to the v3.2.0 milestone Aug 7, 2019
@anntzer
Use warnings.warn, not logging.warning, in microseconds locator warning.
bed898d 
Otherwise something like
```
from pylab import *
from matplotlib import dates; from datetime import *
plt.plot([datetime(1990, 1, 1), datetime(1990, 1, 1) + timedelta(microseconds=1500)], [0, 0])
plt.show()
```
results in the same warning being emitted multiple times *for every
draw* (e.g. when zooming/panning), which is pretty needless spam.
@anntzer
Copy link
Contributor Author

anntzer commented Aug 7, 2019

rebased

@anntzer anntzer mentioned this pull request Aug 7, 2019
Closed
@timhoffm timhoffm merged commit a8d2738 into matplotlib:master Aug 7, 2019
@anntzer anntzer deleted the microwarn branch August 7, 2019 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jklymak jklymak jklymak approved these changes

@timhoffm timhoffm timhoffm approved these changes

Assignees
No one assigned
Labels
topic: date handling
Projects
None yet
Milestone
v3.2.0
Development

Successfully merging this pull request may close these issues.
3 participants
@anntzer @jklymak @timhoffm