Skip to content

Deprecate get/set_*ticks minor positional use #15006

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 9, 2019
Merged

Deprecate get/set_*ticks minor positional use #15006

merged 1 commit into from
Aug 9, 2019

Conversation

timhoffm
Copy link
Member

@timhoffm timhoffm commented Aug 8, 2019 •
edited
Loading

PR Summary

minor should become keyword-only in future versions.

PR Checklist

  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@timhoffm timhoffm added this to the v3.2.0 milestone Aug 8, 2019
ImportanceOfBeingErnest
ImportanceOfBeingErnest approved these changes Aug 9, 2019
View reviewed changes
Copy link
Member

@ImportanceOfBeingErnest ImportanceOfBeingErnest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is useful, even in itself, because it prevents people from trying stuff like

 ax.set_xticks([1,2,3],[1,2,3])

which currently does work, but is a wrong use of the API.

@jklymak jklymak merged commit 442049e into matplotlib:master Aug 9, 2019
@timhoffm timhoffm deleted the deprecate-positional-minor branch August 9, 2019 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anntzer anntzer anntzer approved these changes

@ImportanceOfBeingErnest ImportanceOfBeingErnest ImportanceOfBeingErnest approved these changes

Assignees
No one assigned
Labels
API: changes
Projects
None yet
Milestone
v3.2.0
Development

Successfully merging this pull request may close these issues.
4 participants
@timhoffm @anntzer @ImportanceOfBeingErnest @jklymak