Skip to content

Fix cross-references in examples. #15060

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 15, 2019

Conversation

QuLogic
Copy link
Member

@QuLogic QuLogic commented Aug 15, 2019

PR Summary

Not everything works due to missing upstream documentation or missing setup in our code, but I only touched the examples directory for now.

PR Checklist

  • [N/A] Has Pytest style unit tests
  • Code is Flake 8 compliant
  • [N/A] New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • [N/A] Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • [N/A] Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

"GridHelperCurveLinear": [
"doc/gallery/axisartist/demo_floating_axes.rst:17",
"doc/gallery/axisartist/demo_floating_axes.rst:18",
"floating_axes.FloatingSubplot": [
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New because for some reason this isn't in the documentation.

],
"font_manager.FontProperties": [
"doc/gallery/text_labels_and_annotations/font_file.rst:14"
],
"ConciseDateConverter": [
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't appear in matplotlib.dates documentation.

This example lists the attributes of an `FT2Font` object, which describe global
font properties. For individual character metrics, use the `Glyph` object, as
returned by `load_char`.
This example lists the attributes of an `.FT2Font` object, which describe
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not yet fixed because our C extensions don't seem to be in the documentation.

@timhoffm timhoffm added this to the v3.2.0 milestone Aug 15, 2019
@timhoffm
Copy link
Member

Not attempting to backport as that will likely cause conflicts and 3.2 is not too far away.

@timhoffm timhoffm merged commit 82249b8 into matplotlib:master Aug 15, 2019
@QuLogic QuLogic deleted the fix-xref-examples branch August 15, 2019 04:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants