-
-
Notifications
You must be signed in to change notification settings - Fork 7.9k
Fix eps hatching in MacOS Preview #15064
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix eps hatching in MacOS Preview #15064
Conversation
Looks good. Do we having hatching tests? |
We do, but I don't think any of them check (e)ps output. |
Does this still break #6228 ? |
I don't think this breaks #6228. |
Also, it would be better if someone else can confirm the results, since I only tried this on my own laptop. |
Some clarification to this path from my side. When I plotted with hatching in PyCharm, its own viewer |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't test on OSX, but this seems right (and thus ghostscript buggy? dunno) -- fill
should clear the current path, so we need to save it with gsave
/grestore
to keep it available for stroke
.
PR Summary
Hatching in EPS figures doesn't show up in Preview on MacOS X as reported in #8289.
This PR fixes the problem.
PR Checklist