Skip to content

Add FontManager.addfont to register fonts at specific paths. #15068

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 19, 2019

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented Aug 16, 2019

The naming (without underscore) is similar to findfont.

I chose to provide an API adding a single path rather than also wrap
findSystemFonts given that the later is basically just a recursive glob
(Path(...).glob("**/*.ttf")).

addfont has no deduplication logic but I think that's fine (really
ttflist should be ttfset, but that's a bigger API change).

findSystemFonts already assumes that the font extension gives the font
type so assuming the same in addfont seems fine.

See discussion starting at https://gitter.im/matplotlib/matplotlib?at=5d54195ea4efe3718dff8b64, attn @andrzejnovak @tacaswell

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

The naming (without underscore) is similar to findfont.

I chose to provide an API adding a single path rather than also wrap
findSystemFonts given that the later is basically just a recursive glob
(``Path(...).glob("**/*.ttf")``).

addfont has no deduplication logic but I think that's fine (really
ttflist should be ttfset, but that's a bigger API change).

findSystemFonts already assumes that the font extension gives the font
type so assuming the same in addfont seems fine.
@tacaswell tacaswell added this to the v3.2.0 milestone Aug 19, 2019
@dopplershift dopplershift merged commit 2be4767 into matplotlib:master Aug 19, 2019
@anntzer anntzer deleted the addfont branch August 19, 2019 19:50
@anntzer anntzer mentioned this pull request Jan 4, 2023
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants