Fix cross-references in API changes < 2.0.0. #15070
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anntzer
reviewed
Aug 17, 2019
| - *xy* -> set where the arrow points to | ||
| - *anncoords* -> set the units of the annotation location | ||
| - *xycoords* -> set the units of the point location | ||
| - ``set_position()`` -> `.Annotation` only set location of annotation |
There was a problem hiding this comment.
'.Annotation.set_position'? (quotes -> backticks)
There was a problem hiding this comment.
There is no .Annotation.set_position; it's on the underlying Text. But this is referring to the Annotation, and the fact that .set_position now works on it correctly, so I'm not sure we want to redirect to Text.
anntzer
reviewed
Aug 17, 2019
| Tightened validation so that only {'tip', 'tail', 'mid', and 'middle'} (but any | ||
| capitalization) are valid values for the *pivot* keyword argument in the | ||
| `.Quiver` class (and hence `.axes.Axes.quiver` and `.pyplot.quiver` which both | ||
| fully delegate to `.Quiver`). Previously any input matching 'mid.*' would be |
There was a problem hiding this comment.
needs quoting to avoid asterisk being interpreted as italic (just below too)
There was a problem hiding this comment.
That's only true on GitHub; it's correct in the rendered result.
anntzer
approved these changes
Aug 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
More of the same. No backport since it changes references to code-style for deleted targets.
PR Checklist