Fix missing references in doc build. #15134
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What's wrong with that reference? Why does it not point to the (I'm more interested in why it fails, not so much in making sure this utterly important class gets a link it surely deserves. ;-)) |
|
Because many things in mpl_toolkits have no API entry. Certainly that should probably be fixed; OTOH AttributeCopier is clearly an implementation detail and is not very high in the priority list. |
ImportanceOfBeingErnest
approved these changes
Aug 26, 2019
|
Merging this directly because it fixes the doc builts. If you can maybe extend #15042 (comment) to include what exactly needs to be done for something to aquire "an API entry", that'd be very helpful. |
|
Thanks @anntzer and @ImportanceOfBeingErnest ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
the usual dance
PR Checklist