Support for shorthand hex colors. #15152
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good to me - could you add a quick note in |
|
For reference this is defined at https://www.w3.org/TR/css-color-4/#hex-notation. Likely https://matplotlib.org/tutorials/colors/colors.html and a few other places will also need updating. |
|
I added a line about the change in the colors.py and in the color specification tutorial, as well as a new entry in |
|
A link to the css spec (e.g. the one I posted above) in colors.py would be nice. (Probably not necessary in the tutorial as well.) |
|
👍 Thanks @PatrickFeiring ! |
|
re-milestoned to 3.2 as we have not branched yet so it's going to be in 3.2 not 3.3. |
QuLogic
added a commit
to QuLogic/matplotlib
that referenced
this pull request
Jul 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Added support for shorthand hex colors as described in section 4.2 of the current CSS Color Module Level 4 Working Draft from 5 March 2019.
Examples:
#123 is interpreted as #112233
#123a is interpreted as #112233aa
It is a minor change, and I did this mainly to match expectations for anyone coming from web design (myself including) and to make tasks like specifying softer blacks like #333 or greys like #ccc quicker.
PR Checklist