TST: verify warnings fail the test suite #15169
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
That doesn't seem to be working :p |
|
I think it is working, the The reason that the pre-release is currently passing is that while we were installing the beta, we were actually testing with the system python (which was py36), #15168 has a fix for that, but it is failing during installation of dependencies now. |
timhoffm
approved these changes
Sep 3, 2019
|
Ok, I finally understood it. On the other hand, I'm confused on why we are testing this in our test suite. It doesn't have much to do with Matplotlib. |
|
We set pytest to fail on warnings in our test setup: This is making sure that we don't accidental lose that line but think we were still failing on warnings. |
|
I'm not convinced it's useful, but ok. 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
I expected the tests on azure on preview python to be failing without #15168 so adding a test the will fail if it does not fail on warnings 🤕
The other explanation for it passing is I am confused about if b4 should have the upstream changes that are causing the warnings.
PR Checklist