Skip to content

Autogenerate gca(), gci() from boilerplate.py. #15201

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 20, 2019
Merged

Autogenerate gca(), gci() from boilerplate.py. #15201

merged 1 commit into from
Sep 20, 2019

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented Sep 6, 2019

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@tacaswell tacaswell added this to the v3.3.0 milestone Sep 6, 2019
@jklymak
Copy link
Member

jklymak commented Sep 6, 2019

Confused why we need gci at all? Seems crufty

@anntzer
Copy link
Contributor Author

anntzer commented Sep 6, 2019

Probably to go with gca(), but it's out my fault :)

@timhoffm timhoffm merged commit 9eee66f into matplotlib:master Sep 20, 2019
@anntzer anntzer deleted the autogcai branch September 20, 2019 13:24
@WeatherGod
Copy link
Member

WeatherGod commented Sep 23, 2019 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jklymak jklymak jklymak approved these changes

@timhoffm timhoffm timhoffm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v3.3.0
Development

Successfully merging this pull request may close these issues.
5 participants
@anntzer @jklymak @WeatherGod @timhoffm @tacaswell