-
-
Notifications
You must be signed in to change notification settings - Fork 7.9k
Propagate signature-modifying decorators to pyplot wrappers. #15254
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
b0f1695
to
144b913
Compare
144b913
to
61a21ba
Compare
61a21ba
to
fbffe2f
Compare
e8597f7
to
ce1eed0
Compare
What is the disposition on this PR (asking in relation to #15049)? Looks like the conflict is in generated code, and can be resolved rather simply. |
There's no final decision between this and #14130 yet. In the end, I don't have a very strong opinion anymore on which one to choose. The important thing is that we get one of them in, so that we can properly rename parameters and propagate that to pyplot. Since this is internal functionality, we could even switch out the solution if we realize the other one was better. In practice, we need a second positive review so that this can get merged. The confict is indeed trivial to solve by regenerating the code. |
ce1eed0
to
73746d6
Compare
rebased |
I want to merge, but I'm wondering if there's an example that would trigger this yet? |
@QuLogic I think there are others, but one such example is the The argument (and docstring) were changed in the actual implementation, but pyplot still has the old kwarg (with the new docstring) |
Remove specification for where the old parameter remains supported This was fixed by merging matplotlib#15254
PR Summary
alternative to #14130, see discussion there; attn @timhoffm
PR Checklist