Skip to content

More properties aliases. #15288

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 18, 2019
Merged

More properties aliases. #15288

merged 1 commit into from
Sep 18, 2019

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented Sep 18, 2019

Also make it possible for Axes3D to define additional aliases on top of
Axes.

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@timhoffm
Copy link
Member

For some reason this creates a reference problem with the aliased property:

/home/circleci/project/doc/api/axes_api.rst:248:<autosummary>:1: WARNING: py:obj reference target not found: get_facecolor
/home/circleci/project/doc/api/axes_api.rst:248:<autosummary>:1: WARNING: py:obj reference target not found: set_facecolor

@anntzer
More properties aliases.
9283c28 
Also make it possible for Axes3D to define additional aliases on top of
Axes.
@anntzer
Copy link
Contributor Author

anntzer commented Sep 18, 2019

fixed

@WeatherGod WeatherGod merged commit a93baa1 into matplotlib:master Sep 18, 2019
@anntzer anntzer deleted the morealiases branch September 18, 2019 17:08
@QuLogic QuLogic added this to the v3.3.0 milestone Sep 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WeatherGod WeatherGod WeatherGod approved these changes

@timhoffm timhoffm timhoffm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v3.3.0
Development

Successfully merging this pull request may close these issues.
4 participants
@anntzer @timhoffm @WeatherGod @QuLogic