Skip to content

CI: use python -m to make sure we are using the pip/pytest we want #15300

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

tacaswell
Copy link
Member

PR Summary

Follow up to work in #15168 that discovered we were not actually using the envs we thought we were (as we were not seeing the warnings on 3.8).

Expect this to fail on the 3.8.0b4 for the same reason as #15295

@tacaswell tacaswell added this to the v3.2.0 milestone Sep 18, 2019
Copy link
Member

@timhoffm timhoffm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, conditional on CI pass.

@jklymak
Copy link
Member

jklymak commented Sep 25, 2019

Indeed ti does fail as per #15295. Confused about what we want to do about that? Do you want this merged with the breaking build?

@jklymak jklymak added the Build label Sep 25, 2019
@tacaswell
Copy link
Member Author

tacaswell commented Sep 25, 2019

We should re-run the test when 3.8rc1 comes out (should be in a week or two).

[edited to fix typo in version]

@anntzer
Copy link
Contributor

anntzer commented Sep 25, 2019

We should re-run the test when 2.8rc1 comes out (should be in a week or two).

(mumbles snarky comment about how Guido finally gave in and decided to do a 2.8 release after all ;))

@tacaswell tacaswell closed this Oct 3, 2019
@tacaswell tacaswell reopened this Oct 3, 2019
@tacaswell
Copy link
Member Author

power-cycled to restart CI now that 3.8.0rc1 is available.

@tacaswell
Copy link
Member Author

tacaswell commented Oct 3, 2019

It looks like we are still failing on the python pre-release, but in a different way when compiling numpy....

@tacaswell
Copy link
Member Author

Closing in favor of #15418

@tacaswell tacaswell closed this Oct 14, 2019
@tacaswell tacaswell deleted the tst_azure_envs branch October 14, 2019 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants