Skip to content

Autogenerate footer Copyright year #15305

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 19, 2019
Merged

Autogenerate footer Copyright year #15305

merged 1 commit into from
Sep 19, 2019

Conversation

the-c0d3br34k3r
Copy link
Contributor

PR Summary

Closes #15285
Instead of hardcoding the Copyright
year, which needs to be changed every year,
it now uses datetime to fetch the current year.

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@the-c0d3br34k3r
Autogenerate footer Copyright year
a23d540 
Closes #15285
Instead of hardcoding the Copyright
year, which needs to be changed every year,
it now uses datetime to fetch the current year.
@the-c0d3br34k3r the-c0d3br34k3r mentioned this pull request Sep 19, 2019
Closed
@jklymak
Copy link
Member

jklymak commented Sep 19, 2019

This looks "fine". Not this PR's fault, so happy to merge as is, but why is our footer off centre?

Untitled 2

Built documentation is here: https://25222-1385122-gh.circle-artifacts.com/0/home/circleci/project/doc/build/html/index.html

@jklymak jklymak mentioned this pull request Sep 19, 2019
Closed
@jklymak
Copy link
Member

jklymak commented Sep 19, 2019

Thanks for your first PR!

@jklymak jklymak added this to the v3.3.0 milestone Sep 19, 2019
@the-c0d3br34k3r
Copy link
Contributor Author

@jklymak Thank you.
Btw, for the footer alignment issue, I think it's because of this:

matplotlib/doc/_static/mpl.css

Line 352 in 030157c

text-align: right;

@the-c0d3br34k3r
Copy link
Contributor Author

Yup, the footer alignment issue is because of

matplotlib/doc/_static/mpl.css

Line 352 in 030157c

text-align: right;

With

text-align: right

image

On changing that to

text-align: center
it aligns as expected.

image

@the-c0d3br34k3r
Copy link
Contributor Author

@jklymak Looks like you're way faster than me :)
#15306

@timhoffm timhoffm merged commit db5fb66 into matplotlib:master Sep 19, 2019
@timhoffm
Copy link
Member

Footer alignment will be handled via #15306.

@the-c0d3br34k3r Thanks and congratulations on your first contribution to Matplotlib! Maybe see you back some time.

@the-c0d3br34k3r the-c0d3br34k3r deleted the Autogenerate_Copyright_year branch September 19, 2019 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@story645 story645 story645 approved these changes

@jklymak jklymak jklymak approved these changes

Assignees
No one assigned
Labels
Documentation
Projects
None yet
Milestone
v3.3.0
Development

Successfully merging this pull request may close these issues.

DOC: make copy right year auto-update
4 participants
@the-c0d3br34k3r @jklymak @timhoffm @story645