DOC: center footer #15307
Merged
DOC: center footer #15307
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I dunno. I think this looks better, but I still think its funny that the light blue part extends through the margin but doesn't cover the whole bottom of the site.
|
|
Center is also a bit awkward. Anyway, this will be replaced in the website redesign, and I trust Dora will find a good looking solution. |
|
OK, so leave as is? I'm fine w/ that, but when I reviewed the other PR I really thought the PR must have broken something.... |
|
+/-0 I don't really care. If you feel this is an improvement, you can have my vote. |
|
attn @dorafc |
|
I do think the centered text is an improvement |
tacaswell
approved these changes
Sep 20, 2019
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Sep 20, 2019
timhoffm
added a commit
that referenced
this pull request
Sep 20, 2019
…307-on-v3.2.x Backport PR #15307 on branch v3.2.x (DOC: center footer)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Closes #15306 The footer is right-justified, and at least to me, looks weird considering the text above has a 240pt margin. Not sure this is the right solution. Maybe the footer needs a margin as well, in which case right justification may be OK
PR Checklist